-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lock variables from Cover device state attributes #108
Conversation
@tetienne I will have a look later today, this is something I will need to test a bit more. I am not 100% sure what the previous code did, since this is coming from the original component. |
@iMicknl Normally the data I removed are not used in the cover behavior. They are here only to be used as HA attributes where you can put what you want. |
I don't have covers and can't really appreciate those changes, so I put my faith in you :) |
@tetienne true, but I am not sure if those value are used by automations of people using the current component. I have never used those values, thus I would need to see if this is something where people can depend on. However, I am up for making the cover platform simpler, since there is still some legacy inside. |
I don't see any reason to use these weird variables. It's not something familiar within HA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to have the cover component simplified. If people use the _lock_level
or calculated _lock_timer
, we will gather their feedback at some point.
Some
_lock_xxx
variables was only used fo withindevice_state_attributes
which is IMO useless. Removing them, we once again ease the code with useless boilerplate.