Code enhance

iMattPro · Oct 12, 2021 · 741d68d · 741d68d
1 parent 2ed565f
commit 741d68d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/acp/abbc3_module.php b/acp/abbc3_module.php
@@ -44,6 +44,8 @@ class abbc3_module
 
 	/**
 	 * Constructor
+	 *
+	 * @throws \Exception
 	 */
 	public function __construct()
 	{

diff --git a/core/bbcodes_installer.php b/core/bbcodes_installer.php
@@ -210,12 +210,7 @@ protected function update_bbcode(array $old_bbcode, array $new_bbcode)
 	 */
 	protected function add_bbcode(array $bbcode_data)
 	{
-		$bbcode_id = $this->get_max_bbcode_id() + 1;
-
-		if ($bbcode_id <= NUM_CORE_BBCODES)
-		{
-			$bbcode_id = NUM_CORE_BBCODES + 1;
-		}
+		$bbcode_id = max($this->get_max_bbcode_id(), NUM_CORE_BBCODES) + 1;
 
 		if ($bbcode_id <= BBCODE_LIMIT)
 		{
-Original file line number
+Diff line change
@@ Expand Up / @@ -44,6 +44,8 @@ class abbc3_module @@
     	/**
     	 * Constructor
+    	 *
+    	 * @throws \Exception
     	 */
     	public function __construct()
     	{
@@ Expand Down @@