FIX: record the original exception info when job can be retried

[yiichou]

If a failed job is able to be retried, Sidekiq will

1. catch the original exception
2. append the exception message to the job and push it into retry queue
3. raise a new exception Sidekiq::JobRetry::Skip

when Sidekiq::LogstashJobLogger tries to parse the failed job by #log_job_exception,
the received exception is Sidekiq::JobRetry::Skip and
the recorded error_message, error and error_backtrace are wrong.

[yiichou]

#28

[yiichou]

One more question:

Sidekiq uses error_class to record the exception class name,

but sidekiq-logstash uses payload['error'] = exc.class

Should it be better to use error_class uniformly?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[iMacTia]

Thank you for fixing this @yiichou.
This must have changed at some point because I also noticed this in a recent project I'm working on, but I didn't have time to update this gem yet, thank you so much 🙏 !

[iMacTia]

@yiichou on your point above:

One more question:
Sidekiq uses error_class to record the exception class name,
but sidekiq-logstash uses payload['error'] = exc.class
Should it be better to use error_class uniformly?

Although I understand the will to follow the convention set by Sidekiq, I'm afraid this would be a braking change.
Better not to add it to this PR, we should take this offline into a separate issue and eventually consider it for a future v3.0 release of the gem