Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken with latest Sidekiq #30

Closed
dbussink opened this issue Jun 9, 2022 · 3 comments
Closed

Broken with latest Sidekiq #30

dbussink opened this issue Jun 9, 2022 · 3 comments

Comments

@dbussink
Copy link

dbussink commented Jun 9, 2022

Looks like things are broken with the latest Sidekiq (6.5.0):

{
  "ts":"2022-06-09T12:09:36.898Z",
  "pid":1,
  "tid":"187p",
  "lvl":"WARN",
  "msg":"NameError: uninitialized constant Sidekiq::ExceptionHandler\n\n config.error_handlers.delete_if { |h| h.is_a?(Sidekiq::ExceptionHandler::Logger) }"
}

Since sidekiq/sidekiq#5340 this type no longer exists. I think this logic should be removed entirely since there's no default error handlers configured anymore from what I can see?

@iMacTia
Copy link
Owner

iMacTia commented Jun 9, 2022

Thank you for raising this @dbussink, I'm taking a look into what happened

@iMacTia
Copy link
Owner

iMacTia commented Jun 9, 2022

@dbussink I've fixed this in #31 and just released v2.0.2 in Rubygems
If you could give the new release a try and let me know if it fixed your issue, it would be greatly appreciated

@dbussink
Copy link
Author

@dbussink I've fixed this in #31 and just released v2.0.2 in Rubygems
If you could give the new release a try and let me know if it fixed your issue, it would be greatly appreciated

Sorry for the delay, but looking all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants