Create voucher with , VoucherHub address, Set account as owner, expiration and deal with Authorization #6

gfournieriExec · 2024-03-29T16:07:08Z

For the moment

Constructor

VoucherHub address
Set account as owner
expiration
Store (onlyVoucherOwner) & get authorized account
mapping(address=>bool) public isAuthorized

function createVoucher(accountAddress,voucherTypeId,credit,expiration) onlyAdmin

Deploy new Voucher contract

TODO :
credits
Receive value or Call transferFrom credits from admin to voucher
Call deposit

contracts/VoucherHub.sol

contracts/IVoucherHub.sol

contracts/VoucherHub.sol

contracts/beacon/Voucher.sol

contracts/mocks/IVoucherV2Mock.sol

contracts/beacon/Voucher.sol

Co-authored-by: Jérémy James Toussaint <[email protected]>

test/VoucherHub.test.ts

test/beacon/Voucher.test.ts

Co-authored-by: Jérémy James Toussaint <[email protected]>

contracts/VoucherHub.sol

test/VoucherHub.test.ts

test/beacon/Voucher.test.ts

jeremyjams

👌

…face

contracts/beacon/IVoucher.sol

test/beacon/Voucher.test.ts

gfournieriExec added 11 commits March 26, 2024 17:31

start implementing voucher with type and split test files

a172953

update test and plug voucher with type

3a335d6

clean and add test to get full coverage

2459613

set creditERC20 as voucherHub

b460510

update interfaces

2a303d0

Merge branch 'develop' into feature/create-typed-voucher

b12c70c

add get voucher test for coverage

f65b38e

Update naming files

6e3fb6e

update interface voucher

67847b9

add set authorisation

d7ad6a0

add unauthorization for not owner coverage

31f130c

gfournieriExec requested a review from jeremyjams March 29, 2024 16:07

gfournieriExec changed the base branch from main to develop March 29, 2024 16:07

create common function file in script

b6db8db

gfournieriExec requested a review from zguesmi March 29, 2024 16:20

gfournieriExec self-assigned this Mar 29, 2024

gfournieriExec added 2 commits March 29, 2024 17:20

back spdx

0c1c650

clean unused function in VH test

8aebbb0

jeremyjams reviewed Apr 2, 2024

View reviewed changes

modify IT name

f658893

gfournieriExec marked this pull request as ready for review April 2, 2024 07:24

gfournieriExec and others added 2 commits April 2, 2024 09:42

compute voucherExpiration with block timestamp first

3670867

Erase comment

26160e9

Co-authored-by: Jérémy James Toussaint <[email protected]>

jeremyjams reviewed Apr 2, 2024

View reviewed changes

test/VoucherHub.test.ts Outdated Show resolved Hide resolved

test/beacon/Voucher.test.ts Outdated Show resolved Hide resolved

gfournieriExec added 6 commits April 2, 2024 10:12

update return in getter functions

cf631e7

update name of storage variable here

0e58e98

remove duration0 mistack in IT title

b81040b

change revert with custom error on voucher IT

574b403

remove useless override function

ca53968

update coverage to check if owner is authorized

46ac1c5

gfournieriExec added 4 commits April 3, 2024 10:22

update isAuthorized in internal function

a38b5ec

move private functions at the bottom of the file

72a8765

erase event emission on voucher init + revert when owner setAuthorize

bb714a9

moved back create voucher in voucherHub test

c81c4fe

jeremyjams reviewed Apr 3, 2024

View reviewed changes

test/beacon/Voucher.test.ts Outdated Show resolved Hide resolved

gfournieriExec and others added 2 commits April 3, 2024 16:16

remove useless transaction

b4fd967

Co-authored-by: Jérémy James Toussaint <[email protected]>

reorganise voucher init arg disposition and emited event on creation

eaf789a

zguesmi self-requested a review April 3, 2024 14:42

zguesmi reviewed Apr 3, 2024

View reviewed changes

contracts/VoucherHub.sol Outdated Show resolved Hide resolved

contracts/VoucherHub.sol Show resolved Hide resolved

test/VoucherHub.test.ts Show resolved Hide resolved

test/beacon/Voucher.test.ts Show resolved Hide resolved

jeremyjams approved these changes Apr 3, 2024

View reviewed changes

gfournieriExec added 3 commits April 4, 2024 09:05

remove blank line

6e02605

modify unauthorize test with non owner voucher

e47eac3

update voucher initialize voucherType Id arg name and add it in inter…

80984b8

…face

zguesmi reviewed Apr 4, 2024

View reviewed changes

contracts/beacon/IVoucher.sol Outdated Show resolved Hide resolved

gfournieriExec added 12 commits April 4, 2024 10:11

remove initialize from i voucher

c1ea7f7

commenting test for CI

df8886c

uncomment

657a535

testing for CI

36eb1d6

remove debug CI

0b1446f

comment test to pass CI

1b3e0e4

test only init

76f5195

remove init

6d351a5

add clean workspace and test it

f815043

erase bad stage

ce443af

re-add tests after clean ws CI

65bb9e0

voucher 2 should have duration1

2c764ec

zguesmi approved these changes Apr 4, 2024

View reviewed changes

test/beacon/Voucher.test.ts Show resolved Hide resolved

jeremyjams approved these changes Apr 4, 2024

View reviewed changes

gfournieriExec merged commit aaa0327 into develop Apr 4, 2024
1 check passed

gfournieriExec deleted the feature/create-typed-voucher branch April 4, 2024 11:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create voucher with , VoucherHub address, Set account as owner, expiration and deal with Authorization #6

Create voucher with , VoucherHub address, Set account as owner, expiration and deal with Authorization #6

gfournieriExec commented Mar 29, 2024

jeremyjams left a comment

Create voucher with , VoucherHub address, Set account as owner, expiration and deal with Authorization #6

Create voucher with , VoucherHub address, Set account as owner, expiration and deal with Authorization #6

Conversation

gfournieriExec commented Mar 29, 2024

jeremyjams left a comment

Choose a reason for hiding this comment