Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor voucher tests file #18

Merged
merged 10 commits into from
May 23, 2024
Merged

Refactor voucher tests file #18

merged 10 commits into from
May 23, 2024

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented May 22, 2024

  • Use global variables to remove duplication.
  • Create common used voucher only once in beforeEach block.
  • Create mock orders in beforeEach block.

@zguesmi zguesmi self-assigned this May 22, 2024
@zguesmi zguesmi marked this pull request as ready for review May 22, 2024 13:31
gfournieriExec
gfournieriExec reviewed May 23, 2024
View reviewed changes
test/beacon/Voucher.test.ts Show resolved Hide resolved
test/beacon/Voucher.test.ts Outdated Show resolved Hide resolved
test/beacon/Voucher.test.ts Show resolved Hide resolved
gfournieriExec
gfournieriExec approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@gfournieriExec gfournieriExec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleaning !

@zguesmi zguesmi merged commit f37033e into develop May 23, 2024
2 checks passed
@zguesmi zguesmi deleted the feature/voucher-test-refactoring branch May 23, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfournieriExec gfournieriExec gfournieriExec approved these changes

@jeremyjams jeremyjams Awaiting requested review from jeremyjams

Assignees

@zguesmi zguesmi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zguesmi @gfournieriExec