Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add match orders boost feature on voucher #16

Merged
merged 28 commits into from
Apr 30, 2024

Conversation

gfournieriExec
Copy link
Contributor

@gfournieriExec gfournieriExec commented Apr 29, 2024

Add simply match orders boost, based on match order implementation. Next PR could be add modifiers to check onlyAuthorized and expiration => stack too deep for the moment
Factorized
Implem avec les modifiers et les test

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (965a71f) to head (7932b61).

❗ Current head 7932b61 differs from pull request most recent head fb8ef6d. Consider uploading reports for the commit fb8ef6d to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           develop       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          155       176   +21     
  Branches        21        25    +4     
=========================================
+ Hits           155       176   +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gfournieriExec gfournieriExec self-assigned this Apr 29, 2024
contracts/beacon/Voucher.sol Show resolved Hide resolved
contracts/beacon/Voucher.sol Outdated Show resolved Hide resolved
test/beacon/Voucher.test.ts Outdated Show resolved Hide resolved
test/beacon/Voucher.test.ts Outdated Show resolved Hide resolved
test/beacon/Voucher.test.ts Outdated Show resolved Hide resolved
test/beacon/Voucher.test.ts Outdated Show resolved Hide resolved
contracts/beacon/Voucher.sol Outdated Show resolved Hide resolved
contracts/beacon/Voucher.sol Outdated Show resolved Hide resolved
Copy link
Member

@jeremyjams jeremyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thanks!

test/beacon/Voucher.test.ts Outdated Show resolved Hide resolved
test/beacon/Voucher.test.ts Outdated Show resolved Hide resolved
contracts/beacon/Voucher.sol Outdated Show resolved Hide resolved
contracts/beacon/Voucher.sol Outdated Show resolved Hide resolved
contracts/beacon/Voucher.sol Show resolved Hide resolved
test/beacon/Voucher.test.ts Show resolved Hide resolved
@gfournieriExec gfournieriExec requested a review from zguesmi April 30, 2024 12:55
test/beacon/Voucher.test.ts Show resolved Hide resolved
test/beacon/Voucher.test.ts Outdated Show resolved Hide resolved
test/beacon/Voucher.test.ts Outdated Show resolved Hide resolved
test/beacon/Voucher.test.ts Show resolved Hide resolved
test/beacon/Voucher.test.ts Show resolved Hide resolved
test/beacon/Voucher.test.ts Outdated Show resolved Hide resolved
test/beacon/Voucher.test.ts Outdated Show resolved Hide resolved
test/beacon/Voucher.test.ts Outdated Show resolved Hide resolved
Copy link
Member

@zguesmi zguesmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@gfournieriExec gfournieriExec merged commit 86a5133 into develop Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants