-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add match orders boost feature on voucher #16
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 155 176 +21
Branches 21 25 +4
=========================================
+ Hits 155 176 +21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thanks!
Co-authored-by: Jérémy James Toussaint <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
Add simply match orders boost, based on match order implementation.
Next PR could be add modifiers to checkonlyAuthorized
andexpiration
=>stack too deep
for the momentFactorized
Implem avec les modifiers et les test