Match orders #12
Merged
Match orders #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zguesmi
reviewed
Apr 15, 2024
Co-authored-by: Zied Guesmi <[email protected]> Co-authored-by: gfournieriExec <[email protected]>
zguesmi
reviewed
Apr 15, 2024
contracts/beacon/IVoucher.sol
Outdated
| @@ -6,6 +6,7 @@ pragma solidity ^0.8.20; | |||
| interface IVoucher { | |||
| event AccountAuthorized(address indexed account); | |||
| event AccountUnauthorized(address indexed account); | |||
| event VoucherMatchOrders(bytes32 dealId); | |||
There was a problem hiding this comment.
Suggested change
| event VoucherMatchOrders(bytes32 dealId); | |
| event VoucherOrdersMatched(bytes32 dealId); |
?
There was a problem hiding this comment.
Honestl, I am not sure about this suggestion. I don't know if "VoucherOrders" makes sense.
There was a problem hiding this comment.
Yes thanks, here is Rename match event which sounds the most meaningful option so far 😄 ..!
There was a problem hiding this comment.
Co-authored-by: Zied Guesmi <[email protected]>
zguesmi
reviewed
Apr 15, 2024
Co-authored-by: Zied Guesmi <[email protected]>
zguesmi
approved these changes
Apr 15, 2024
jeremyjams
commented
Apr 15, 2024
Co-authored-by: Zied Guesmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.