V3 hello world (DON'T MERGE) #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…act-dom, and wagmi
…act-dom, and dotenv
…ONNECT_PROJECT_ID
Turo IDapp CLI Integration
…debug not for prod
…documentation-tools into v2-hello-world
…ution-note-green' for improved styling consistency in data access section.
…ple' CSS class for improved styling of solution notes, replacing the previous 'solution-note' class in multiple markdown files. Update content in various sections to reflect the new styling and enhance clarity regarding iExec's privacy features and data protection processes.
…, refine language for clarity, and ensure consistent terminology by replacing 'iExec App' with 'iApp'. Enhance instructions for using the DataProtector SDK and managing data access, while improving overall readability and coherence across multiple sections.
…+ for compatibility
…ncy, improve clarity in requirements, and add tooltips for better user guidance. Refine language in multiple sections for improved readability, including installation instructions for the DataProtector SDK.
…prove user guidance in ProtectData component with additional signing information, and refine language in multiple markdown files for clarity. Update reading time estimates and section titles for consistency.
…phrasing, enhance description of the DataProtector SDK, and improve overall readability in multiple sections.
…iled signing information in the GrantAccess component, refine language for consistency in multiple markdown files, and improve clarity regarding privacy-preserving applications. Update instructions and enhance user guidance throughout the documentation.
…t with detailed tooltip information for improved user guidance. Update existing requirements for clarity and consistency.
…ion to streamline content and improve clarity.
…ng iApp address post-deployment, include troubleshooting tips for Docker BuildKit and AMD64 architecture support, and improve overall user guidance.
…ton and documentation - Introduced a new CouponCode component that generates a unique coupon code based on the user's wallet address and allows copying to clipboard. - Created a useWallet composable to manage wallet connection state and address. - Updated MetamaskButton component to utilize the new useWallet composable for better state management. - Enhanced documentation to include information about the new coupon code feature and updated voucher claim details.
… the description of the $20 voucher offer and improved the link to learn more about Vouchers.
…reamline content and enhance clarity.
… update CSS for improved consistency and readability.
…rage early testers with a new reward message, replace the requirements list with a waiting animation, and rephrase raffle details for clarity and engagement.
…documentation-tools into v3-hello-world
ErwanDecoster
requested changes
Jan 24, 2025
overview/helloWorld/2-protectData.md
Outdated
| - The data object to protect (can contain text, files, JSON data etc.) | ||
| - The name of the protected data | ||
|
|
||
| ```typescript |
There was a problem hiding this comment.
Use ts twoslash for consistency. This should be applied everywhere.
Suggested change
| ```typescript | |
| ```ts twoslash |
Comment on lines
+1
to
+2
| User-agent: * | ||
| Disallow: / |
There was a problem hiding this comment.
Do we really want to not reference this site in the navigation?
| border-radius: var(--border-radius); | ||
| padding: 1.5rem; | ||
| margin: 1.5rem 0; | ||
| border-left: 4px solid #ce2c68; |
There was a problem hiding this comment.
Maybe avoid the left border for better consistency with other documentation pages? same for other solution-note
Suggested change
| border-left: 4px solid #ce2c68; |
Comment on lines
+45
to
+49
| <div class="button-group-voucher"> | ||
| <a href="https://www.iex.ec/voucher" class="yellow-button" target="_blank"> | ||
| Claim your $20 voucher | ||
| </a> | ||
| </div> |
There was a problem hiding this comment.
We should use button component
utils/config.ts
Outdated
| @@ -0,0 +1 @@ | |||
| export const IEXEC_EXPLORER_URL = 'https://explorer.iex.ec/bellecour/dataset/'; | |||
Comment on lines
+1
to
+9
| /// <reference types="vite/client" /> | ||
|
|
||
| interface ImportMetaEnv { | ||
| readonly VITE_WALLET_CONNECT_PROJECT_ID: string; | ||
| } | ||
|
|
||
| interface ImportMeta { | ||
| readonly env: ImportMetaEnv; | ||
| } |
ErwanDecoster
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Need small change
I also create a PR to switch to Reown instead of only use Metamask #123
Co-authored-by: Erwan Decoster <[email protected]>
…ript highlighting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to create a preview link