Fix for v4.1.0 - deprecated nested serializers #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iDebugAll any chance you can review this PR? This is blocking our upgrade to v4.1.0 and higher. Thanks! |
iDebugAll
approved these changes
Sep 23, 2024
|
@iDebugAll Thanks for merging this so quickly. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #53 which is caused by the deprecation of nested serializers in upstream Netbox.
I don't have any prior experience with Django before this, so if there is a better or more optimal way to solve this I'm open to suggestions.
I tested this in my dev environment and
manage.py migratenow completes successfully and I'm able to start the dev server, and interact with phonebox custom models.