Upgrade jest to v21 #103
Upgrade jest to v21 #103
Conversation
|
Enzyme migration guide: |
packages/core/src/Checkbox.js
Outdated
| @@ -57,7 +57,9 @@ class Checkbox extends PureComponent { | |||
| } | |||
|
|
|||
| updateInputIndeterminate() { | |||
| this.inputRef.indeterminate = this.props.indeterminate; | |||
| if (this.inputRef) { | |||
There was a problem hiding this comment.
This makes coverage drops slightly. Wanna cover this?
There was a problem hiding this comment.
This change is make for enzyme v3 previously. But i misunderstood the real reason that make the test failed, so I revert it back first.
In v3, ref callback will not fired in shallow test. Since ref is actual returned a DOM, but shallow test do not handled it. But shallow test still support some life cycle methods. (Check enzymejs/enzyme#318)
So the better solution is use mount() API to test the component which use ref to some action.
There was a problem hiding this comment.
In next PR, I will switch the shallow() to mount() in checkbox test.
This change is made for enzyme v3 previously. During v3, ref wont be called in shallow test, use mount() API instead.
cjies
force-pushed
the
CJ/upgrade_jest
branch
from
b32a64c to
5aa9045
Compare
|
Rebased with latest |
|
good to go |
Implement
v21.2.1.Fix bugs:
[Checkbox] Updateindeterminateattr after the checkbox input element was generated.scrollNodeis existing.Note
Actually I plan to upgrade enzyme to v3 too, but much APIs are changed and this issue... 😕
I need more times to fix them XD