Fix SponsorBlock zero videoDuration bug

[iBicha]

Fixes a bug where SponsorBlock reports that the video has a duration of zero.

Reported from Reddit https://www.reddit.com/r/selfhosted/comments/zb07p0/comment/iyq52av/?utm_source=share&utm_medium=web2x&context=3

[iBicha]

Although the current fix is to skip segments with videoDuration = 0, the official SponsorBlock extension does not skip it.
Will change the approach to use the actual video duration instead.

[iBicha]

Added a follow up task to this in the roadmap, this fix should do for now

[mchangrh]

VideoDuration is not checked locally since it has been unreliable, as you have witnessed first hand. Segments are displayed regardless and if there's a detected duration mismatch when it's checked, the server will hide segments and not send them to any clients.

[iBicha]

VideoDuration is not checked locally since it has been unreliable, as you have witnessed first hand. Segments are displayed regardless and if there's a detected duration mismatch when it's checked, the server will hide segments and not send them to any clients.

@mchangrh from the docs

videoDuration: float // Duration of video when submission occurred (to be used to determine when a submission is out of date). 0 when unknown. +- 1 second

Should I ignore the videoDuration field entirely?

[mchangrh]

Yes, I wrote those docs. It was used briefly for the client and it's still used on the server side but it's unreliable for use in clients but retained for backwards compatibility. I would suggest you ignore the field entirely