Reload translations whenever namespaces passed to useTranslation() change #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaslohrer
commented
Jun 20, 2019
| @@ -74,7 +74,7 @@ export function useTranslation(ns, props = {}) { | |||
| if (bindI18nStore && i18n) | |||
| bindI18nStore.split(' ').forEach(e => i18n.store.off(e, boundReset)); | |||
| }; | |||
| }, []); // define props to trigger using effect on rerender (none here) | |||
| }, [namespaces.join()]); // re-run effect whenever list of namespaces changes | |||
There was a problem hiding this comment.
I thought it might be safer not to rely on object identity in case people pass inlined arrays like useTranslation(["x", "y"]) that are recreated on every render. That's why I'm turning the namespaces array into a string first.
There was a problem hiding this comment.
yes...saw that...think that's rather clever
|
was published in [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dynamically changing the
namespacespassed touseTranslation()over time, they are now reloaded and trigger a re-render. This reimplements the behavior first introduced in #523 as it was likely broken in the release of the new hooks-based API.See #817 (comment) and #520 for context.