Add support for nonExplicitSupportedLngs #1930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
nonExplicitSupportedLngs
and is related to #1412. This features adds the possibility to support multiple variants of a language (de-AT
,de-CH
andde-DE
) with a single JSON file (e.g.public/locales/de/common.js
).During the work on this PR I noticed that the the
default
value infallbackLng
should always be loaded. At least this is how I interprete this testcase. Although this is related to #1927, the fix is part of this PR, becausenonExplicitSupportedLngs
depends on the same logic. Regarding the test-case above: I addeden-US
to supportedlocales
and removeden
from theinitialI18nStore
, because I think this should be the expected behavior. Is this correct @adrai?Currently the combination
fallbackLng
with a function andnonExplicitSupportedLngs: true
is not supported. Mainly because I didn't know how this could be implemented 😅 But I guess that the use cases for this combination should be very rare.I'm looking forward to your feedback @adrai, thank you!
Checklist
npm run test
Checklist (for documentation change)