refactor: Set cookieSameSite to strict by default (#776)

i18next · Jul 29, 2020 · ecb70d6 · ecb70d6
1 parent 205d11e
commit ecb70d6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/__tests__/config/create-config.test.ts b/__tests__/config/create-config.test.ts
@@ -83,6 +83,7 @@ describe('create configuration in non-production environment', () => {
 
       expect(config.detection.order).toEqual(['cookie', 'header', 'querystring'])
       expect(config.detection.caches).toEqual(['cookie'])
+      expect(config.detection.cookieSameSite).toEqual('strict')
 
       expect(config.react.wait).toEqual(true)
 
@@ -188,6 +189,7 @@ describe('create configuration in non-production environment', () => {
 
       expect(config.detection.order).toEqual(['cookie', 'header', 'querystring'])
       expect(config.detection.caches).toEqual(['cookie'])
+      expect(config.detection.cookieSameSite).toEqual('strict')
 
       expect(config.react.wait).toEqual(true)
 

diff --git a/src/config/default-config.ts b/src/config/default-config.ts
@@ -27,9 +27,10 @@ export const defaultConfig = {
   ignoreRoutes: ['/_next/', '/static/', '/public/', '/api/'],
   customDetectors: [],
   detection: {
+    caches: ['cookie'],
+    cookieSameSite: 'strict',
     lookupCookie: 'next-i18next',
     order: ['cookie', 'header', 'querystring'],
-    caches: ['cookie'],
   },
   react: {
     wait: true,