fix fallback lng option during translations #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will merge this...wasn't to aware that one can pass fallbackLng on calling translation....might be some addition by contribution. |
|
thanks ! any ETA? |
|
might get a new version out this or next week. stay tuned. |
jamuhl
added a commit
that referenced
this pull request
Jun 23, 2015
fix fallback lng option during translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation state in features that you can give the
fallbackLngoption during translation but it does not seem to work. I noticed calls totoLanguageswith 2 arguments (lng&fallbackLng) but this function did not seem to handle this case properly so I added some code to do it.Careful: the option fallbackLng still does not work when the
lngoption is not provided during initialization. I added a hack in my code to provide it in all cases because I did not have the time to fix this case too.