Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix variables not nullable in request callback typescript definition #143

Merged

Conversation

tomdardev
Copy link
Contributor

@tomdardev tomdardev commented Jun 27, 2024

The RequestCallback type definition didn't mention that both of its parameters are nullable. This is especially confusing since the documentation explicitly mentions the response parameter as being nullable.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@adrai adrai merged commit 94b46b7 into i18next:master Jun 27, 2024
2 checks passed
@adrai
Copy link
Member

adrai commented Jun 27, 2024

thank you... will be included in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants