Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nplurals=1 #92

Merged
merged 2 commits into from
Apr 1, 2020
Merged

fix nplurals=1 #92

merged 2 commits into from
Apr 1, 2020

Conversation

OleksiiKukuruza
Copy link

fix for languages with nplurals=1

correct formatting:
msgid "{{count}} apple"
msgid_plural "{{count}} apples"
msgstr[0] "{{count}}つのリンゴ"

current behavior:

msgid "{{count}} apple"
msgstr "{{count}} apples"

@coveralls
Copy link

coveralls commented Mar 31, 2020

Coverage Status

Coverage increased (+0.06%) to 96.624% when pulling 7f4d6c4 on OleksiiKukuruza:master into 6ef5a20 on i18next:master.

@perrin4869
Copy link
Contributor

Thank you for the PR! Could you add regression tests?

@perrin4869 perrin4869 merged commit 99ca31c into i18next:master Apr 1, 2020
@perrin4869
Copy link
Contributor

Thank you!!! Some day I'd like to make this code more functional ><;;
Will publish shortly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants