Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect skipUntranslated option when used with keyasareference option #73

Merged
merged 2 commits into from
Oct 24, 2018
Merged

respect skipUntranslated option when used with keyasareference option #73

merged 2 commits into from
Oct 24, 2018

Conversation

forfolias
Copy link
Contributor

Fix a bug when using both --keyasareference and --skipUntranslated options it doesn't respect the --skipUntranslated option.

@jamuhl jamuhl requested a review from perrin4869 September 21, 2018 11:06
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 97.248% when pulling 3cfe0c3 on forfolias:master into 9b2d3cc on i18next:master.

@perrin4869 perrin4869 merged commit 5f25b09 into i18next:master Oct 24, 2018
@perrin4869
Copy link
Contributor

@forfolias Thank you for the PR, and sorry for the delay!!! Will publish as a patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrin4869 perrin4869 Awaiting requested review from perrin4869

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forfolias @coveralls @perrin4869