Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Portuguese plurals in line with i18next and CLDR #68

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

rankida
Copy link
Contributor

@rankida rankida commented Oct 12, 2017

This PR addresses #67 and takes the same approach as the associated i18next fix i18next/i18next@c5113fb

The plural forms for Portuguese have been changed.
Now pt-PT is the exception to the rule, taking plural=(n != 1) where as all other forms of Portuguese (including pt and pt-BR) take plural=(n > 1). This is in accordance with the Unicode spec for Portuguese (pt) and European Portuguese (pt-PT).

For i18next this was seen as a breaking change and bumped a major.

@coveralls
Copy link

coveralls commented Oct 12, 2017

Coverage Status

Coverage increased (+0.03%) to 97.235% when pulling e587b5f on rankida:pt-br into 0cb0b82 on i18next:master.

@perrin4869 perrin4869 self-assigned this Oct 15, 2017
@perrin4869 perrin4869 merged commit dce9c2a into i18next:master Oct 16, 2017
@rankida rankida deleted the pt-br branch November 5, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants