recognize nested object arrays and handle appropriately

[ripvannwinkler]

The key

{ "test": { array: [{ inner1: "testing" }]}}

should become:

msgid "test##array##inner1"
msgstr "testing"

Before this patch, it resulted in:

msgid "test##array"
msgstr "[object Object]"

Checklist

• only relevant code is changed (make a diff before you submit the PR)
• run tests npm run test
• tests are included
• documentation is changed or added

[ripvannwinkler]

Found this bug attempting to convert a JSON file with deeply nested keys. For whatever reason, the original code didn't anticipate key/value nodes inside arrays. This patch checks to see if the value is an array and contains at least one object, and recurses if so.

[jamuhl]

This looks very limited to one case - should it not be more like JSON flattens array in most implementations like:

{ "test": { array: [{ inner1: "testing", inner2: "testing" }, { inner1: "testing", inner2: "testing" }]}}

// becomes
msgid "test##array##0##inner1"
...
msgid "test##array##0##inner2"
...
msgid "test##array##1##inner1"
...
msgid "test##array##1##inner2"
...

[ripvannwinkler]

@jamuhl You are correct. This is actually what it does. I mistyped the result in my PR comment. If you look at the test files, this should confirm your expected result.

{
  "parent": {
    "questions": [
      {
        "title": "test question",
        "answer": "test answer"
      }
    ]
  }
}

becomes

msgid ""
msgstr ""
"Project-Id-Version: i18next-conv\n"
"mime-version: 1.0\n"
"Content-Type: text/plain; charset=utf-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Plural-Forms: nplurals=2; plural=(n != 1)\n"
"POT-Creation-Date: 2021-04-13T17:16:37.311Z\n"
"PO-Revision-Date: 2021-04-13T17:16:37.311Z\n"
"Language: en\n"

msgid "parent##questions##0##title"
msgstr "test question"

msgid "parent##questions##0##answer"
msgstr "test answer"

To be clear, I did not modify the logic that determines keys when flattening - I just added the extra recursion step for nested objects inside arrays.

[jamuhl]

@perrin4869 looks good to me...do you have time to publish a new version? or should I?!?

[jamuhl]

@ripvannwinkler sorry, almost forgot about this one.

finally published in [email protected]