fix(product): review fixes

CHANGELOG.md

@@ -5,7 +5,8 @@
 * add config `commerce.checkout.orderService.skipCartValidation` to disable cart validation that happens right before placing an order in the OrderService
 
 **search**
-* fixed fake service to interpret sort options and gives away empty promotion
+* **Breaking:** fixed fake service to interpret sort options and gives away empty promotion
+* removed deprecation notice from fields `Asc` and `Desc` in `SortOption` struct
 
 ## v3.11.0
 

product/module.go

@@ -88,7 +88,7 @@ commerce: {
 			if enabled {
 			  jsonTestDataFolder?: string & !=""
 			  jsonTestDataLiveSearch?: string & !=""
-			  sorting: [SearchSorting, ...SearchSorting]
+			  sorting: [...SearchSorting]
 			}
 			deliveryCodes: [...string] | *["testCode1", "testCode2"]
 		}

search/domain/service.go

@@ -63,10 +63,8 @@ type (
 		// SelectedDesc true if sorting by this field is active
 		SelectedDesc bool
 		// Asc - represents the field that is used to trigger ascending search.
-		// Deprecated: use "Field" and "SelectedAsc" instead to set which field should be sortable
 		Asc string // Should it be deprecated ?? marked as deprecated in 2019 and used in 2020
 		// Desc - represents the field that is used to trigger descending search.
-		// Deprecated: use "Field" and "SelectedDesc" instead to set which field should be sortable
 		Desc string // Should it be deprecated ?? marked as deprecated in 2019 and used in 2020
 	}