checkout: rename client sdk data field (#350)

Co-authored-by: nicole.schmelzer <[email protected]>
i-love-flamingo · Nov 25, 2021 · 4ad5afb · 4ad5afb
1 parent 100608f
commit 4ad5afb
Show file tree

Hide file tree

Showing 6 changed files with 59 additions and 131 deletions.
diff --git a/checkout/interfaces/graphql/schema.graphql b/checkout/interfaces/graphql/schema.graphql
@@ -69,7 +69,7 @@ type Commerce_Checkout_PlaceOrderState_State_Redirect implements Commerce_Checko
 type Commerce_Checkout_PlaceOrderState_State_TriggerClientSDK implements Commerce_Checkout_PlaceOrderState_State {
     name: String!
     URL: String!
-    Data: String!
+    data: String!
 }
 
 type Commerce_Checkout_PlaceOrderState_State_ShowWalletPayment implements Commerce_Checkout_PlaceOrderState_State {

diff --git a/docs/openapi/docs.go b/docs/openapi/docs.go
@@ -1030,7 +1030,7 @@ var doc = `{
                     "500": {
                         "description": "Internal Server Error",
                         "schema": {
-                            "$ref": "#/definitions/cartResultError"
+                            "$ref": "#/definitions/productResultError"
                         }
                     }
                 }
@@ -1090,36 +1090,6 @@ var doc = `{
         }
     },
     "definitions": {
-        "ProductAttribute": {
-            "type": "object",
-            "properties": {
-                "Code": {
-                    "description": "Code is the internal attribute identifier",
-                    "type": "string"
-                },
-                "CodeLabel": {
-                    "description": "CodeLabel is the human readable (perhaps localized) attribute name",
-                    "type": "string"
-                },
-                "Label": {
-                    "description": "Label is the human readable (perhaps localized) attribute value",
-                    "type": "string"
-                },
-                "RawValue": {
-                    "description": "RawValue is the untouched original value of the attribute"
-                },
-                "UnitCode": {
-                    "description": "UnitCode is the internal code of the attribute values measuring unit",
-                    "type": "string"
-                }
-            }
-        },
-        "ProductAttributes": {
-            "type": "object",
-            "additionalProperties": {
-                "$ref": "#/definitions/ProductAttribute"
-            }
-        },
         "application.PlaceOrderPaymentInfo": {
             "type": "object",
             "properties": {
@@ -1745,17 +1715,6 @@ var doc = `{
                 }
             }
         },
-        "cartResultError": {
-            "type": "object",
-            "properties": {
-                "Code": {
-                    "type": "string"
-                },
-                "Message": {
-                    "type": "string"
-                }
-            }
-        },
         "checkoutError": {
             "type": "object",
             "properties": {
@@ -1771,7 +1730,7 @@ var doc = `{
             "type": "object",
             "properties": {
                 "Error": {
-                    "$ref": "#/definitions/cartResultError"
+                    "$ref": "#/definitions/productResultError"
                 },
                 "Product": {},
                 "Success": {
@@ -1794,7 +1753,7 @@ var doc = `{
                 },
                 "Error": {
                     "description": "Contains details if success is false",
-                    "$ref": "#/definitions/cartResultError"
+                    "$ref": "#/definitions/productResultError"
                 },
                 "Success": {
                     "type": "boolean"
@@ -1904,6 +1863,10 @@ var doc = `{
                 }
             }
         },
+        "domain.Attributes": {
+            "type": "object",
+            "additionalProperties": {}
+        },
         "domain.Badge": {
             "type": "object",
             "properties": {
@@ -2148,7 +2111,7 @@ var doc = `{
                     "$ref": "#/definitions/domain.PriceInfo"
                 },
                 "Attributes": {
-                    "$ref": "#/definitions/ProductAttributes"
+                    "$ref": "#/definitions/domain.Attributes"
                 },
                 "AvailablePrices": {
                     "type": "array",
@@ -2356,6 +2319,17 @@ var doc = `{
                 }
             }
         },
+        "productResultError": {
+            "type": "object",
+            "properties": {
+                "Code": {
+                    "type": "string"
+                },
+                "Message": {
+                    "type": "string"
+                }
+            }
+        },
         "validation.ItemValidationError": {
             "type": "object",
             "properties": {

diff --git a/docs/openapi/swagger.json b/docs/openapi/swagger.json
@@ -1014,7 +1014,7 @@
                     "500": {
                         "description": "Internal Server Error",
                         "schema": {
-                            "$ref": "#/definitions/cartResultError"
+                            "$ref": "#/definitions/productResultError"
                         }
                     }
                 }
@@ -1074,36 +1074,6 @@
         }
     },
     "definitions": {
-        "ProductAttribute": {
-            "type": "object",
-            "properties": {
-                "Code": {
-                    "description": "Code is the internal attribute identifier",
-                    "type": "string"
-                },
-                "CodeLabel": {
-                    "description": "CodeLabel is the human readable (perhaps localized) attribute name",
-                    "type": "string"
-                },
-                "Label": {
-                    "description": "Label is the human readable (perhaps localized) attribute value",
-                    "type": "string"
-                },
-                "RawValue": {
-                    "description": "RawValue is the untouched original value of the attribute"
-                },
-                "UnitCode": {
-                    "description": "UnitCode is the internal code of the attribute values measuring unit",
-                    "type": "string"
-                }
-            }
-        },
-        "ProductAttributes": {
-            "type": "object",
-            "additionalProperties": {
-                "$ref": "#/definitions/ProductAttribute"
-            }
-        },
         "application.PlaceOrderPaymentInfo": {
             "type": "object",
             "properties": {
@@ -1729,17 +1699,6 @@
                 }
             }
         },
-        "cartResultError": {
-            "type": "object",
-            "properties": {
-                "Code": {
-                    "type": "string"
-                },
-                "Message": {
-                    "type": "string"
-                }
-            }
-        },
         "checkoutError": {
             "type": "object",
             "properties": {
@@ -1755,7 +1714,7 @@
             "type": "object",
             "properties": {
                 "Error": {
-                    "$ref": "#/definitions/cartResultError"
+                    "$ref": "#/definitions/productResultError"
                 },
                 "Product": {},
                 "Success": {
@@ -1778,7 +1737,7 @@
                 },
                 "Error": {
                     "description": "Contains details if success is false",
-                    "$ref": "#/definitions/cartResultError"
+                    "$ref": "#/definitions/productResultError"
                 },
                 "Success": {
                     "type": "boolean"
@@ -1888,6 +1847,10 @@
                 }
             }
         },
+        "domain.Attributes": {
+            "type": "object",
+            "additionalProperties": {}
+        },
         "domain.Badge": {
             "type": "object",
             "properties": {
@@ -2132,7 +2095,7 @@
                     "$ref": "#/definitions/domain.PriceInfo"
                 },
                 "Attributes": {
-                    "$ref": "#/definitions/ProductAttributes"
+                    "$ref": "#/definitions/domain.Attributes"
                 },
                 "AvailablePrices": {
                     "type": "array",
@@ -2340,6 +2303,17 @@
                 }
             }
         },
+        "productResultError": {
+            "type": "object",
+            "properties": {
+                "Code": {
+                    "type": "string"
+                },
+                "Message": {
+                    "type": "string"
+                }
+            }
+        },
         "validation.ItemValidationError": {
             "type": "object",
             "properties": {

diff --git a/docs/openapi/swagger.yaml b/docs/openapi/swagger.yaml
@@ -1,27 +1,4 @@
 definitions:
-  ProductAttribute:
-    properties:
-      Code:
-        description: Code is the internal attribute identifier
-        type: string
-      CodeLabel:
-        description: CodeLabel is the human readable (perhaps localized) attribute
-          name
-        type: string
-      Label:
-        description: Label is the human readable (perhaps localized) attribute value
-        type: string
-      RawValue:
-        description: RawValue is the untouched original value of the attribute
-      UnitCode:
-        description: UnitCode is the internal code of the attribute values measuring
-          unit
-        type: string
-    type: object
-  ProductAttributes:
-    additionalProperties:
-      $ref: '#/definitions/ProductAttribute'
-    type: object
   application.PlaceOrderPaymentInfo:
     properties:
       Amount:
@@ -516,13 +493,6 @@ definitions:
       Type:
         type: string
     type: object
-  cartResultError:
-    properties:
-      Code:
-        type: string
-      Message:
-        type: string
-    type: object
   checkoutError:
     properties:
       Code:
@@ -533,7 +503,7 @@ definitions:
   controller.APIResult:
     properties:
       Error:
-        $ref: '#/definitions/cartResultError'
+        $ref: '#/definitions/productResultError'
       Product: {}
       Success:
         type: boolean
@@ -548,7 +518,7 @@ definitions:
       DataValidationInfo:
         type: object
       Error:
-        $ref: '#/definitions/cartResultError'
+        $ref: '#/definitions/productResultError'
         description: Contains details if success is false
       Success:
         type: boolean
@@ -620,6 +590,9 @@ definitions:
       Delivery:
         $ref: '#/definitions/cart.Delivery'
     type: object
+  domain.Attributes:
+    additionalProperties: {}
+    type: object
   domain.Badge:
     properties:
       Code:
@@ -789,7 +762,7 @@ definitions:
       ActivePrice:
         $ref: '#/definitions/domain.PriceInfo'
       Attributes:
-        $ref: '#/definitions/ProductAttributes'
+        $ref: '#/definitions/domain.Attributes'
       AvailablePrices:
         items:
           $ref: '#/definitions/domain.PriceInfo'
@@ -937,6 +910,13 @@ definitions:
       OrderNumber:
         type: string
     type: object
+  productResultError:
+    properties:
+      Code:
+        type: string
+      Message:
+        type: string
+    type: object
   validation.ItemValidationError:
     properties:
       ErrorMessageKey:
@@ -1631,7 +1611,7 @@ paths:
         "500":
           description: Internal Server Error
           schema:
-            $ref: '#/definitions/cartResultError'
+            $ref: '#/definitions/productResultError'
       summary: Get the payment status of current cart (or last placed cart)
       tags:
       - Payment

diff --git a/test/integrationtest/projecttest/graphql/generated.go b/test/integrationtest/projecttest/graphql/generated.go
diff --git a/...aphql/schema/flamingo.me_flamingo-commerce_v3_checkout_interfaces_graphql-Service.graphql b/...aphql/schema/flamingo.me_flamingo-commerce_v3_checkout_interfaces_graphql-Service.graphql
@@ -69,7 +69,7 @@ type Commerce_Checkout_PlaceOrderState_State_Redirect implements Commerce_Checko
 type Commerce_Checkout_PlaceOrderState_State_TriggerClientSDK implements Commerce_Checkout_PlaceOrderState_State {
     name: String!
     URL: String!
-    Data: String!
+    data: String!
 }
 
 type Commerce_Checkout_PlaceOrderState_State_ShowWalletPayment implements Commerce_Checkout_PlaceOrderState_State {