Dev cli sessions #1

i-davydenko · 2023-08-23T13:38:22Z

Why I did it

Give ability to:

configure limit for active login sessions.
configure ssh-server / serial console autologout timeout
configure sysrq-capabilities (enable / disable)

Work item tracking

Microsoft ADO (number only):

How I did it

Add new service that responsible for serial configuration;
Update existing flows for extended ssh-server configurations in hostcfgd;
Add YANG model to support new configuration.

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

ssh_server
serial_console

A picture of a cute animal (not mandatory but encouraged)

…bors over iBGP Session (sonic-net#16705) What I did: Enable Sending BGP Community over internal neighbors over iBGP Session Microsoft ADO: 25268695 Why I did: Without this change BGP community send by e-BGP Peers are not carry-forward to other e-BGP peers. str2-xxxx-lc1-2# show bgp ipv6 20c0:a801::/64 BGP routing table entry for 20c0:a801::/64, version 52141 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65500 2603:10e2:400::6 from 2603:10e2:400::6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) Last update: Tue Sep 26 16:08:26 2023 str2-xxxx-lc1-2# show ip bgp 192.168.35.128/25 BGP routing table entry for 192.168.35.128/25, version 52688 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65502 3.3.3.6 from 3.3.3.6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) Last update: Tue Sep 26 15:45:51 2023 After the change str2-xxxx-lc2-2(config)# router bgp 65100 str2-xxxx-lc2-2(config-router)# address-family ipv4 str2-xxxx-lc2-2(config-router-af)# neighbor INTERNAL_PEER_V4 send-community str2-xxxx-lc2-2(config-router-af)# exit str2-xxxx-lc2-2(config-router)# address-family ipv6 str2-xxxx-lc2-2(config-router-af)# neighbor INTERNAL_PEER_V6 send-community str2-xxxx-lc1-2# show bgp ipv6 20c0:a801::/64 BGP routing table entry for 20c0:a801::/64, version 52400 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65500 2603:10e2:400::6 from 2603:10e2:400::6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) **Community: 1111:1111** Last update: Tue Sep 26 16:10:19 2023 str2-xxxx-lc1-2# show ip bgp 192.168.35.128/25 BGP routing table entry for 192.168.35.128/25, version 52947 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65502 3.3.3.6 from 3.3.3.6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) **Community: 1111:1111** Last update: Tue Sep 26 16:10:09 2023 Signed-off-by: Abhishek Dosi <[email protected]>

dgsudharsan · 2023-11-03T03:26:25Z

files/build_templates/init_cfg.json.j2

@@ -135,6 +135,18 @@
            "special_class": "true"
        }
    },
+    "SSH_SERVER": {


Please don't define defaults here. Previously it was discussed and removed. Refer the link below. Please define your defaults in the

https://github.com/sonic-net/sonic-buildimage/pull/14513#discussion_r1246974269

dgsudharsan · 2023-11-03T03:35:20Z

src/sonic-host-services

Please don't include submodule updates when raising to sonic-net unless there is some cyclic dependency

dgsudharsan · 2023-11-03T03:42:38Z

files/image_config/cli_sessions/serial-config.sh

+sudo echo $SYSRQ_CONF > /proc/sys/kernel/sysrq
+
+# generate env file for profile.d to set auto-logout timeout for serial consoles.
+sonic-cfggen -d -t /usr/share/sonic/templates/tmout-env.sh.j2 > /etc/profile.d/tmout-env.sh


Can you clarify how and when this tmout-env.sh is executed?

tmout-env.sh (and all other placed under /etc/profile.d/) runned on each new shell session startup

dgsudharsan · 2023-11-03T03:46:34Z

src/sonic-host-services-data/templates/sshd_config

@@ -0,0 +1,121 @@
+#	$OpenBSD: sshd_config,v 1.101 2017/03/14 07:19:07 djm Exp $


Where is this file used? Is this added by mistake?

yes, this was a mistake. removed.

dgsudharsan · 2023-11-03T03:47:55Z

src/sonic-yang-models/yang-models/sonic-serial-console.yang

@@ -0,0 +1,37 @@
+//filename:  sonic-serial-console.yang


Please add unit test for this file. Refer to other yang model PRs for example

dgsudharsan · 2023-11-03T03:48:15Z

src/sonic-yang-models/yang-models/sonic-ssh-server.yang

@@ -40,6 +45,20 @@ module sonic-ssh-server {
                        }
                    }
                }
+                leaf inactivity_timeout {


Please add UT for these changes

…kernel 6.1 and bookworm (sonic-net#16954) * sonic-platform-modules-cel: broadcom: adapt for kernel 6.1 and bookworm The i2c_driver->remove API declaration has been updated to return void instead of int, as part of cleanup patches in 6.1. More details can be referred from here: [1]. Update the remove API definition in the modules accordingly and cleanup variables that go unused from the remove API. Update python build commands for bookworm. The packaging based on calling setup.py is deprecated and using build module/pip utility is the recommended method for python packaging/installation. Further details can be referred to from here: [2], [3]. The build module is picky about the package information file, which needs to be either setup.py or pyproject.toml. Additionally, fix formatting inconsistencies in debian/changelog reported by `dh_installchangelogs` during the build. Tested the changes by compiling the changes as below: make sonic-slave-bash NOBUSTER=1 NOBULLSEYE=1 sudo dpkg -i target/debs/bookworm/linux-headers-6.1.0-11-2-*.deb cd platform/broadcom/sonic-platform-modules-cel KVERSION=6.1.0-11-2-amd64 dpkg-buildpackage Also verified the python scripts under the sonic-platform-modules-cel with pyflakes to ensure no new errors are flagged (with exception of unused modules). References: [1] - torvalds/linux@ed5c2f5f [2] - https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.htm [3] - 0b20a48 (Update Python build commands for Bookworm, 2023-09-07) Signed-off-by: Ramasamy Chandramouli <[email protected]> * platform/pddf: i2c: adapt for kernel 6.1 and bookworm * Fixup i2c_driver->remove API due to changes in the function prototype (ref: [1]). * Cleanup `MODULE_SUPPORTED_DEVICE` macros that were cleaned up in the upstream (ref: [2]). * Sanitize python packaging and installation using the `build` module instead of calling the setup.py directly (ref: [3]. [4]). Tested the changes by compiling pddf module as below: make sonic-slave-bash NOBUSTER=1 NOBULLSEYE=1 sudo dpkg -i target/debs/bookworm/linux-headers-6.1.0-11-2-*.deb cd platform/pddf/i2c KVERSION=6.1.0-11-2-amd64 dpkg-buildpackage References: [1] - torvalds/linux@ed5c2f5f [2] - torvalds/linux@6417f031 [2] - https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.htm [3] - 0b20a48 (Update Python build commands for Bookworm, 2023-09-07) Signed-off-by: Ramasamy Chandramouli <[email protected]> * platform/broadcom: include platform-modules-cel in builds With pddf modules patched for 6.1, platform-modules-cel can be compiled and included in the final image. Testing by building sonic-broadcom.bin/sonic-broadcom-dnx.bin. Signed-off-by: Ramasamy Chandramouli <[email protected]> * pddf/i2c: revert correct rootdir for pip install The pip install directory has been set to test-pkg1/ for testing the build and incorrectly retained as is. Revert this to the correct path $(PACKAGE_PRE_NAME). Signed-off-by: Ramasamy Chandramouli <[email protected]> * platform/broadcom: include pddf/modules-cel in the base package Without this change, the modules were built but not packaged in the final .bin. The final sonic-broadcom.bin has been tested for bootup on Celestica's Silverstone platform. admin@sonic:~$ uname -a Linux sonic 6.1.0-11-2-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.38-4 (2023-08-08) x86_64 GNU/Linux admin@sonic:~$ show platform summary Platform: x86_64-cel_silverstone-r0 HwSKU: Silverstone ASIC: broadcom ASIC Count: 1 Serial Number: R4009B2F062504LK200024 Model Number: N/A Hardware Revision: N/A admin@sonic:~$ show version | head SONiC Software Version: SONiC.g0aad6c67c-rachandr SONiC OS Version: 12 Distribution: Debian 12.2 Kernel: 6.1.0-11-2-amd64 Build commit: 0aad6c67c Build date: Thu Oct 26 07:13:47 UTC 2023 Built by: rachandr@AZUHPS14 Platform: x86_64-cel_silverstone-r0 Signed-off-by: Ramasamy Chandramouli <[email protected]> --------- Signed-off-by: Ramasamy Chandramouli <[email protected]>

…ded ssh-server tree.

update tests for ssh-server model

i-davydenko force-pushed the dev-cli-sessions branch from 51980c7 to 7129333 Compare October 10, 2023 09:25

i-davydenko force-pushed the dev-cli-sessions branch 2 times, most recently from 4fd537b to 33ac45f Compare October 27, 2023 23:01

dgsudharsan suggested changes Nov 3, 2023

View reviewed changes

i-davydenko force-pushed the dev-cli-sessions branch 3 times, most recently from 0c9367c to 7913bf0 Compare November 8, 2023 08:47

dgsudharsan approved these changes Nov 23, 2023

View reviewed changes

Ivan Davydenko added 3 commits December 15, 2023 19:01

[cli-sessions] update configuration templates, default configs

7fd7f2b

[cli-sessions] Update YAML models with new serial-console tree, exten…

fba6a5f

…ded ssh-server tree.

[cli-sessions] Implement tests for serial-colsome model,

f370175

update tests for ssh-server model

i-davydenko force-pushed the dev-cli-sessions branch from 7913bf0 to f370175 Compare December 15, 2023 17:55

i-davydenko merged commit f370175 into master Dec 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev cli sessions #1

Dev cli sessions #1

i-davydenko commented Aug 23, 2023 •

edited

Loading

dgsudharsan Nov 3, 2023

dgsudharsan Nov 3, 2023

dgsudharsan Nov 3, 2023

i-davydenko Nov 3, 2023

dgsudharsan Nov 3, 2023

i-davydenko Nov 7, 2023

dgsudharsan Nov 3, 2023

dgsudharsan Nov 3, 2023

		@@ -0,0 +1,121 @@
		# $OpenBSD: sshd_config,v 1.101 2017/03/14 07:19:07 djm Exp $

Dev cli sessions #1

Dev cli sessions #1

Conversation

i-davydenko commented Aug 23, 2023 • edited Loading

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

i-davydenko commented Aug 23, 2023 •

edited

Loading