Table widget #53
Table widget #53
Conversation
Copied from https://github.com/iomega/paired-data-form/tree/master/app/src/fields and adjusted to new rjsf
✅ Deploy Preview for wonderful-noether-53a9e8 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@sverhoeven can you merge origin/main into this branch? |
|
Main has been merged |
There was a problem hiding this comment.
Looks decent and seems to work well. Did I understand correctly that you already used this code elsewhere? Would it make sense to point to the source? Also, happy to see the extended documentation. Have you considered contributing some of these options back to react-json-schema-form? Would it make sense?
| ? ( | ||
| <label> | ||
| {s.title} | ||
| <span className='required'>*</span> |
There was a problem hiding this comment.
Do we have an example of required parameters in the kitchensink or storyboards?
There was a problem hiding this comment.
Good catch, I have added a storybook and found that * was not shown everywhere it should have. Now it is shown in the column head and in popup.
And added storybooks for required fields
Thanks for reviewing. I have added a comment to point to the source at https://github.com/iomega/paired-data-form/blob/master/app/src/fields/TableFieldTemplate.tsx I was thinking of making something similar to https://github.com/RXNT/react-json-schema-form-extras , but have not had the time yet |
In PR #50 we have several parameters which are array of objects. These can be rendered as a table in the form.
Table examples can be found in
yarn storybookThe usage of the table widget is document in the new
docs/ui/Schema.mdfile. Also the other ui fields are documented in this file (fixes #51).Should be merged after #50 as this PR branches of from it.