-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune defaults from submitted data #46
Conversation
✔️ Deploy Preview for wonderful-noether-53a9e8 ready! 🔨 Explore the source changes: d73b885 🔍 Inspect the deploy log: https://app.netlify.com/sites/wonderful-noether-53a9e8/deploys/62345ed93e96d50008ac5de0 😎 Browse the preview: https://deploy-preview-46--wonderful-noether-53a9e8.netlify.app |
Can't submit because submitting the global config requires an uploaded molecules file, and I don't have one. Getting the following error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sverhoeven nice recursive function :-)
I noticed that a couple of test functions require a change in the length of array/object props. I don't really understand why this behavior makes sense. I can think of cases where the length is in itself a significant thing, even if the values are all defaults. But perhaps that is not applicable to our use case?
You can download a pdb file from https://www.rcsb.org/ for example https://files.rcsb.org/download/5T89.pdb |
For Yep it gets cryptic after double nest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes.
Thanks for reviewing |
Fixes #24
To see the defaults being pruned
Global parameters
button.cores
parameter.cores
parameter should show up again.You can do similar things for the nodes.