-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start item number from 1 instead of 0 #136
Conversation
✅ Deploy Preview for i-vresse-workflow-builder ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 66.68% 66.74% +0.05%
==========================================
Files 57 57
Lines 4049 4065 +16
Branches 336 337 +1
==========================================
+ Hits 2700 2713 +13
- Misses 1345 1348 +3
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f1efcc4
to
e56bf34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me.
Nice, this also updated indexeable for tablefield, see http://localhost:6007/?path=/story/tablefield--array-of-object-with-index-column
I do however have some consistency remarks:
Can you also update the docs?
At https://github.com/i-VRESSE/workflow-builder/blob/130-start-list-with-1/docs/uiSchema.md?plain=1#L146 the 3
should be changed to 4
.
Update unit and integration tests Added playwright headed script for local use
e56bf34
to
cecb743
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks for the contribution.
The list item number start from 1 instead of 0
Closes #130
Changes made:
test:headed
to haddock3-download app to view integration tests locallyHow to test: