support pulseaudio in raspberrypi #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the systemd service file to support pulseaudio, this is the way to run gmrender-resurrect |
hzeller
requested changes
Oct 25, 2017
| @@ -25,17 +25,29 @@ INITIAL_VOLUME_DB=-10 | |||
| # 'aplay -L'), then gmediarenderer will use that ALSA device to play | |||
| # audio. Otherwise, whatever default is configured for gstreamer for the | |||
| # '$DAEMON_USER' is used. | |||
| ALSA_DEVICE="sysdefault" | |||
| RET=`dpkg -l pulseaudio` | |||
There was a problem hiding this comment.
Here, you are making the choice of pulseaudio vs. Alsa dependent on the existence of a particular packet, which sounds like it will result in non-repeatable results: if accidentally a pulseaudio package is installed, suddenly the way gmrender works is changing, which can make things surprising.
So I suggest to rather have this as a variable at the top (USE_PULSEAUDIO=1 or something).
|
Did you get a chance to address the requested change ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i also want to add the logrotate as I write a log in the service now.