Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dropdown hover colors instead of active colors #6

Merged
merged 2 commits into from
Feb 12, 2014
Merged

Use dropdown hover colors instead of active colors #6

merged 2 commits into from
Feb 12, 2014

Conversation

jeffbowen
Copy link
Contributor

In a Bootstrap 3 dropdown, an item's hover/focus state has a light gray background (@dropdown-link-hover-bg) with dark gray text (@dropdown-link-hover-color).

See https://github.com/twbs/bootstrap/blob/master/less/dropdowns.less#L73-L81

In a Bootstrap 3 dropdown, an item's hover/focus state  has a light gray
background (@dropdown-link-hover-bg) with dark gray text
(@dropdown-link-hover-color).

See https://github.com/twbs/bootstrap/blob/master/less/dropdowns.less#L73-L81
@jeffbowen
Copy link
Contributor Author

Take a peek at http://getbootstrap.com/components/#dropdowns to see a live Bootstrap 3 dropdown.

@hyspace
Copy link
Owner

hyspace commented Feb 12, 2014

Thank you for your PR

Yes, I know, and I mentioned it in readme.md.

But different to Bootstrap, typeahead.js does not focus the link when using keyboard to choose suggestions. If I change the background-color to @dropdown-link-hover-color, it will be harder for user to notice the active item.

But yeah, you are right, it is more important to be consistent with bootstrap.

hyspace added a commit that referenced this pull request Feb 12, 2014
Use dropdown hover colors instead of active colors
@hyspace hyspace merged commit 9e2537e into hyspace:master Feb 12, 2014
hyspace added a commit that referenced this pull request Feb 12, 2014
@jeffbowen
Copy link
Contributor Author

Ah, I just now saw your old note in the previous readme.md. Sorry I missed that before. I understand your reasoning. But yeah, I think consistency with Bootstrap is probably best. This is easy enough for people to override if they want to. Thanks for the quick response and all your work on this! Makes my life a lot easier.

@hyspace
Copy link
Owner

hyspace commented Feb 12, 2014

You are welcome. I learned a lot from maintaining this small project and I'm glad I was able to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants