-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkinsfile: Add root repository and submodule repositories as safe directories #2449
Conversation
The Jenkinsfile might be the better place for the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we cannot do anything against having a different user than the dir owner here?
Have to trust you here. 🙂
There probably is something we can do against having a different user than the dir owner. However, so far, I do not know how to achieve it. Since this problem is currently blocking CI runs, I would use this workaround now to be able to perform CI runs again. The user-owner discrepancy is captured in #2450. |
After the security vulnerability CVE-2022-24765, the latest git version available in ubuntu 20.04 was patched.
With this patch, git checks the owner of the top-level directory and does not perform a git command if the owner is not the current user. This check can be disabled for a repository by adding it as a safe directory, i.e.,
git config --global --add safe.directory <dir>
.In a current CI run, the user is
root
, but the files and directories in the cloned Hyrise project directory have the owner113
.This PR adds the directory of the root repository and the directories of the submodule repositories as safe directories to avoid CI errors of the following kind:
References
fatal: unsafe repository (REPO is owned by someone else)
with ubuntu 20.04 container actions/checkout#760