Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

block to page will lose the block reference #1

Closed
karlz97 opened this issue Oct 1, 2021 · 4 comments
Closed

block to page will lose the block reference #1

karlz97 opened this issue Oct 1, 2021 · 4 comments

Comments

@karlz97
Copy link

karlz97 commented Oct 1, 2021 •
edited
Loading

This plugin was so cool, I want this feature since I begin to use logseq. Thank you very much for creating it.
Currently, when the block or its sub block has been referred, 'turn to page' will make the reference invalid.
It will be perfect if you can find a way to solve it! thanks again!
@hyrijk
Copy link
Owner

hyrijk commented Oct 1, 2021

This plugin remove sub block and create in new page, so the reference will be invalid.
plugin api moveBlock can keep reference no change, but it has some bug, it will fixed in logseq next release, and I will refactor this plugin with moveBlock api

@karlz97
Copy link
Author

karlz97 commented Oct 1, 2021

cool!!! looking forward to the new version then. Thanks for replying!

hyrijk added a commit that referenced this issue Oct 10, 2021
@hyrijk
feat: add reference check #1
39d3a8c
@hyrijk hyrijk mentioned this issue Feb 15, 2022
Closed
@hyrijk hyrijk mentioned this issue Mar 27, 2022
Closed
hyrijk added a commit that referenced this issue Mar 27, 2022
@hyrijk
feat: refactor with moveBlock api #1 #6 #9
0f73829
hyrijk added a commit that referenced this issue Mar 27, 2022
@hyrijk
Merge pull request #10 from hyrijk/feature/move-block
4c4de2a 
feat: refactor with `moveBlock` api #1 #6 #9
@hyrijk hyrijk closed this as completed Mar 27, 2022
@hyrijk
Copy link
Owner

hyrijk commented Mar 27, 2022

fixed in 1.3.0

@karlz97
Copy link
Author

karlz97 commented Mar 27, 2022

Cool! Just updated and tried it, works perfectly!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hyrijk @karlz97