refactor/improve monitor mode selection #8804
Open
+385
−425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikalco
force-pushed
the
improve_monitor_rule_mode_selection
branch
from
9980f8a to
f527bc4
Compare
Open
1 task
ikalco
force-pushed
the
improve_monitor_rule_mode_selection
branch
from
e997038 to
d922726
Compare
|
edit: |
ikalco
force-pushed
the
improve_monitor_rule_mode_selection
branch
from
8c14725 to
7030c98
Compare
|
ready for review rebased + fixed |
ikalco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
aims to
also fixes format selection trying to use INVALID
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Is it ready for merging, or does it need work?
yes probably
maybe some other people should test too, idk who tho