Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake: adding clang-tools to devShell #6916

Merged
merged 1 commit into from
Jul 17, 2024
Merged

flake: adding clang-tools to devShell #6916

merged 1 commit into from
Jul 17, 2024

Conversation

Ciflire
Copy link
Contributor

@Ciflire Ciflire commented Jul 17, 2024

Describe your PR, what does it fix/add?

It adds the clang-tools package to the devShell containing the clangd formatter used to format Hyprland's code apparently (.clang-format file exists)

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

I don't know how there can be so much diff, i just use the nix fmt command, the real change is line 101

Is it ready for merging, or does it need work?

It is ready for merging though i would like to propose to change the formatter from alejandra to nixfmt-rfc-style
I will add this change to this PR if wanted

@vaxerski vaxerski requested a review from fufexan July 17, 2024 17:36
Formatted with `nix fmt` command don't know why so much diff
@fufexan
Copy link
Member

fufexan commented Jul 17, 2024

Alejandra's formatting seems not to be as idempotent as advertised. Fixed though.

@fufexan fufexan merged commit 300228b into hyprwm:main Jul 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants