-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix floating clipbox scale #3907
Conversation
you can use vecTransformedSize instead. It's the same. |
added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I told you long ago, on the road
wait, this needs to be rethinked. |
why are we adding the entire monitor here? We should just translate it by the workspace offset oops you wanna do it or should I? |
you can do it if you want. as long as the scale thing gets fixed lol |
I can't repro so I can just suggest you try this: CRegion rg = pWindow->getFullWindowBoundingBox().translate(-pMonitor->vecPosition).scale(pMonitor->scale);
rg.add(CBox{0, 0, pMonitor->vecSize.x, pMonitor->vecSize.y}); into CRegion rg = pWindow->getFullWindowBoundingBox().translate(-pMonitor->vecPosition + PWORKSPACE->m_vRenderOffset.vec()).scale(pMonitor->scale); |
yea seems to do it. I added that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
top g thanks!
Describe your PR, what does it fix/add?
Fix floating clipbox scale. Should fix the window getting clipped incorrectly during workspace transition? Not 100% sure but works for me
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No
Is it ready for merging, or does it need work?
Ready