Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update pseudoSize after window moved by mouse. #3873

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

Dickby
Copy link
Contributor

@Dickby Dickby commented Nov 17, 2023

Describe your PR, what does it fix/add?

Fixes #3574
Prevents a pseudoTiled window size gets changed after moving it with the mouse.
That size change makes sense when a floating window is turned to a pseudoTiled, but not after a mouse move.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Is it ready for merging, or does it need work?

I tested it, and it seems to work.
I think it's ready, but double check please.

@Dickby Dickby changed the title Don't update pseudoSize after window moved by mouse. Fixes Don't update pseudoSize after window moved by mouse. Fixes https://github.com/hyprwm/Hyprland/issues/3574 Nov 17, 2023
@Dickby Dickby changed the title Don't update pseudoSize after window moved by mouse. Fixes https://github.com/hyprwm/Hyprland/issues/3574 Don't update pseudoSize after window moved by mouse. Fixes Nov 17, 2023
@Dickby Dickby changed the title Don't update pseudoSize after window moved by mouse. Fixes Don't update pseudoSize after window moved by mouse. Fixes #3574 Nov 17, 2023
@Dickby Dickby changed the title Don't update pseudoSize after window moved by mouse. Fixes #3574 Don't update pseudoSize after window moved by mouse. Fixes https://github.com/hyprwm/Hyprland/issues/3574 Nov 17, 2023
@Dickby Dickby changed the title Don't update pseudoSize after window moved by mouse. Fixes https://github.com/hyprwm/Hyprland/issues/3574 Don't update pseudoSize after window moved by mouse. Nov 17, 2023
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vaxerski vaxerski merged commit 6ad5f26 into hyprwm:main Nov 18, 2023
@imxyy1soope1
Copy link

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pseudo window get resized on every drag
3 participants