Crash if togglegroup off while dwindle:no_gaps_when_only = 1

[suderman]

Hyprland Version

System/Version info

Hyprland, built from branch  at commit cba1ade848feac44b2eda677503900639581c3f4  ().
Date: 2024-05-04
Tag: , commits: @COMMITS@

flags: (if any)


System Information:
System name: Linux
Node name: kit
Release: 6.8.9
Version: #1-NixOS SMP PREEMPT_DYNAMIC Thu May  2 14:35:35 UTC 2024


GPU information: 
01:00.0 VGA compatible controller [0300]: NVIDIA Corporation AD103 [GeForce RTX 4070 Ti SUPER] [10de:2705] (rev a1) (prog-if 00 [VGA controller])


os-release: ANSI_COLOR="1;34"
BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="24.05.20240503.e9be424"
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
IMAGE_ID=""
IMAGE_VERSION=""
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 24.05 (Uakari)"
SUPPORT_URL="https://nixos.org/community.html"
VERSION="24.05 (Uakari)"
VERSION_CODENAME=uakari
VERSION_ID="24.05"


plugins:

Bug or Regression?

Bug

Description

Toggling a group OFF (so the the windows return as separate tiles) can cause Hyprland to crash if using the Dwindle layout and settings no_gaps_when_only = 1

How to reproduce

general:layout = dwindle
dwindle:no_gaps_when_only = 1

1. Create a window and togglegroup ON
2. Create another window (or more) inside this group
3. togglegroup OFF
4. Restart Hyprland because it crashed :-(

Crash reports, logs, images, videos

No response

[vaxerski]

crash report please

[suderman]

Fresh out of the crash oven, thank you sir:

hyprlandCrashReport42935.txt

[sungyoonc]

d2899a6 is the first bad commit

[vaxerski]

can you try on git?

[suderman]

Afraid it won't build for me if I point my flake to the latest commit.

I normally stick to tagged releases, so I don't know if this is an unrelated rabbit hole:

sudo nixos-rebuild --flake /etc/nixos#cog boot
building the system configuration...
error: builder for '/nix/store/yk4qfb8xsw7qqr0s6iqig63i00spjq5n-hyprland-0.40.0+date=2024-05-07_375e77e.drv' failed with exit code 1;
       last 10 log lines:
       > -- Setting precompiled headers
       > -- Setting link libraries
       > Could not open input file: No such file or directory
       > Could not open input file: No such file or directory
       > Could not open input file: No such file or directory
       > Could not open input file: No such file or directory
       > Couldn't load proto
       > -- Checking for module 'tomlplusplus'
       > --   Found tomlplusplus, version 3.4.0
       > -- Configuring incomplete, errors occurred!
       For full logs, run 'nix log /nix/store/yk4qfb8xsw7qqr0s6iqig63i00spjq5n-hyprland-0.40.0+date=2024-05-07_375e77e.drv'.
error: 1 dependencies of derivation '/nix/store/n51jn8nzjjz7l96g74mda98b42b59y59-activation-script.drv' failed to build
error: 1 dependencies of derivation '/nix/store/3hmrzkgzqp4cjjkb3bf13mz245bniggk-desktops.drv' failed to build
error: 1 dependencies of derivation '/nix/store/0bvfja7sik56r3lxa8w8crqcbz9gij74-home-manager-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/q8vzs75qz0xxfli89b4qv0dc78dr15m6-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/ly4x00hr7mlym8zp2i7hfhaf8hclz6jz-xdg-desktop-portal-hyprland-1.3.1+date=2024-04-25_0fe8404.drv' failed to build
error: 1 dependencies of derivation '/nix/store/00f4yl50qz8qjxw2jjnknrxlyf7inddi-nixos-system-cog-24.05.20240505.25865a4.drv' failed to build

This is the output of nix log /nix/store/yk4qfb8xsw7qqr0s6iqig63i00spjq5n-hyprland-0.40.0+date=2024-05-07_375e77e.drv:

@nix { "action": "setPhase", "phase": "unpackPhase" }
Running phase: unpackPhase
unpacking source archive /nix/store/0y8lfff2na6swy57x3qgcjnvmg3f8q4h-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: configurePhase
fixing cmake files...
cmake flags: -GNinja -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/084xmij2d2g4nk7yjr6gjk17haih34zx-hyprland-0.40.0+date=2024-05-07_375e77e/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/084xmij2d2g4nk7yjr6gjk17haih34zx-hyprland-0.40.0+date=2024-05-07_375e77e/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/084xmij2d2g4nk7yjr6gjk17haih34zx-hyprland-0.40.0+date=2024-05-07_375e77e/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/084xmij2d2g4nk7yjr6gjk17haih34zx-hyprland-0.40.0+date=2024-05-07_375e77e/share/doc/Hyprland -DCMAKE_INSTALL_INFODIR=/nix/store/084xmij2d2g4nk7yjr6gjk17haih34zx-hyprland-0.40.0+date=2024-05-07_375e77e/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/rxnjdm1h153s8fid70pfzqk69bwqby2a-hyprland-0.40.0+date=2024-05-07_375e77e-man/share/man -DCMAKE_INSTALL_OLDINCLUDEDIR=/nix/store/8v0askvjhyfn7fknqbvxigjd4h5p1kwz-hyprland-0.40.0+date=2024-05-07_375e77e-dev/include -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/8v0askvjhyfn7fknqbvxigjd4h5p1kwz-hyprland-0.40.0+date=2024-05-07_375e77e-dev/include -DCMAKE_INSTALL_SBINDIR=/nix/store/084xmij2d2g4nk7yjr6gjk17haih34zx-hyprland-0.40.0+date=2024-05-07_375e77e/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/084xmij2d2g4nk7yjr6gjk17haih34zx-hyprland-0.40.0+date=2024-05-07_375e77e/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/084xmij2d2g4nk7yjr6gjk17haih34zx-hyprland-0.40.0+date=2024-05-07_375e77e/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_SYSROOT= -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/k9pxn9rdy5d2081612zx4i177kzzyvkn-gcc-wrapper-13.2.0/bin/strip -DCMAKE_RANLIB=/nix/store/k9pxn9rdy5d2081612zx4i177kzzyvkn-gcc-wrapper-13.2.0/bin/ranlib -DCMAKE_AR=/nix/store/k9pxn9rdy5d2081612zx4i177kzzyvkn-gcc-wrapper-13.2.0/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/084xmij2d2g4nk7yjr6gjk17haih34zx-hyprland-0.40.0+date=2024-05-07_375e77e -DNO_XWAYLAND:BOOL=FALSE -DLEGACY_RENDERER:BOOL=FALSE -DNO_SYSTEMD:BOOL=FALSE 
-- The C compiler identification is GNU 13.2.0
-- The CXX compiler identification is GNU 13.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /nix/store/k9pxn9rdy5d2081612zx4i177kzzyvkn-gcc-wrapper-13.2.0/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/k9pxn9rdy5d2081612zx4i177kzzyvkn-gcc-wrapper-13.2.0/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Gathering git info
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
�[31mCMake Error at CMakeLists.txt:32 (add_subdirectory):
  The source directory

    /build/source/subprojects/udis86

  does not contain a CMakeLists.txt file.

�[0m
-- Setting up wlroots
-- Found PkgConfig: /nix/store/39nq7p6jcm9m3xqqm99skwmgsqw4pbbg-pkg-config-wrapper-0.29.2/bin/pkg-config (found version "0.29.2")
-- Found WaylandScanner at /nix/store/wfh7w6rfcsnscs7w745pllry2n3wjqcl-wayland-1.22.0-bin/bin/wayland-scanner
-- Found wayland-protocols at //nix/store/byysaxsxa8bgqdypczmnxr84yy1ynqjx-wayland-protocols-1.35/share/wayland-protocols
-- Configuring Hyprland in Release with CMake
-- Checking deps...
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found OpenGL: /nix/store/qady90492hsb01i96amgb8z6q24bv9kd-libGL-1.7.0/lib/libOpenGL.so  found components: GLES3
-- Checking for modules 'xkbcommon;uuid;wayland-server;wayland-client;wayland-cursor;wayland-protocols;cairo;pango;pangocairo;pixman-1;libdrm;libinput;hwdata;libseat;libdisplay-info;libliftoff;libudev;gbm;hyprwayland-scanner>=0.3.4;hyprlang>=0.3.2;hyprcursor>=0.1.7'
--   Found xkbcommon, version 1.5.0
--   Found uuid, version 2.39.3
--   Found wayland-server, version 1.22.0
--   Found wayland-client, version 1.22.0
--   Found wayland-cursor, version 1.22.0
--   Found wayland-protocols, version 1.35
--   Found cairo, version 1.18.0
--   Found pango, version 1.51.2
--   Found pangocairo, version 1.51.2
--   Found pixman-1, version 0.43.4
--   Found libdrm, version 2.4.120
--   Found libinput, version 1.25.0
--   Found hwdata, version 0.381
--   Found libseat, version 0.8.0
--   Found libdisplay-info, version 0.1.1
--   Found libliftoff, version 0.4.1
--   Found libudev, version 255
--   Found gbm, version 24.0.5
--   Found hyprwayland-scanner, version 0.3.4
--   Found hyprlang, version 0.5.1
--   Found hyprcursor, version 0.1.7
-- Looking for execinfo.h
-- Looking for execinfo.h - found
-- Configuration supports execinfo
-- Looking for backtrace in execinfo
-- Looking for backtrace in execinfo - not found
-- Looking for sys/timerfd.h
-- Looking for sys/timerfd.h - found
-- Checking for module 'epoll-shim'
--   No package 'epoll-shim' found
-- XWAYLAND Enabled (NO_XWAYLAND not defined) checking deps...
-- Checking for modules 'xcb;xwayland;xcb-util;xcb-render;xcb-xfixes;xcb-icccm;xcb-composite;xcb-res;xcb-ewmh'
--   Found xcb, version 1.16
--   Found xwayland, version 23.2.6
--   Found xcb-util, version 0.4.1
--   Found xcb-render, version 1.16
--   Found xcb-xfixes, version 1.16
--   Found xcb-icccm, version 0.4.2
--   Found xcb-composite, version 1.16
--   Found xcb-res, version 1.16
--   Found xcb-ewmh, version 0.4.2
-- Checking for module 'xcb-errors'
--   Found xcb-errors, version 1.0.1
-- SYSTEMD support is requested (NO_SYSTEMD not defined)...
-- Setting precompiled headers
-- Setting link libraries
Could not open input file: No such file or directory
Could not open input file: No such file or directory
Could not open input file: No such file or directory
Could not open input file: No such file or directory
Couldn't load proto
-- Checking for module 'tomlplusplus'
--   Found tomlplusplus, version 3.4.0
-- Configuring incomplete, errors occurred!

[vaxerski]

see pinned issue #5891

[suderman]

That solved my NixOS build problem, thanks!

Unfortunately, the same steps above still crash Hyprland for me. :-(

hyprlandCrashReport3023.txt

Outside of these tests for you, I've switched to dwindle:no_gaps_when_only = 2 (where the border is still displayed) which avoids the crash altogether.

[vaxerski]

crash report bork, can you bt -full https://wiki.hyprland.org/Crashes-and-Bugs/#obtaining-a-debug-stacktrace

[suderman]

OK, first time I've manually built Hyprland or run in debug, so hopfully I got this right:

dump.txt

btw, the project's flake is missing gdb - after running nix develop, I had to also run nix-shell -p gdb for coredumpctl debug Hyprland to work.