Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local install python in favour of hdev and fix tests #17

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

jon-betts
Copy link
Contributor

@jon-betts jon-betts commented Jun 4, 2021

For: https://github.com/hypothesis/tox-pip-sync/issues/14 and https://github.com/hypothesis/hdev/issues/44

This removes the install python script and replaces it with the hdev install-python command. This also includes the fix for tox-pip-sync preventing testing updating.

Testing notes

I don't know if you're really going to want to do this for all these very similar PR's but here's how you would:

Install python script

  • make format - Check that the python install works
  • Change the first version number in .python-versions
  • make format - You should see Python start installing
  • If you wait for it to finish you can re-run make format and it should not be installed again

tox-pip-sync fix:

  • rm .tox/.tox -rf - To ensure you have up to date tox-pip-sync
  • Run make test
  • Edit the main __init__.py in the src/<package_name> dir
  • Add raise Exception("live!")
  • Run make test
  • The tests should fail - In main this would use the same code as the first step and work fine

@jon-betts jon-betts added bug Something isn't working tech debt labels Jun 4, 2021
@jon-betts jon-betts self-assigned this Jun 4, 2021
@jon-betts jon-betts merged commit 627f565 into master Jun 4, 2021
@jon-betts jon-betts deleted the rm-python-install branch June 4, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants