Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display loading indicator in table when loading members #9150

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Display loading indicator in table when loading members #9150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions h/static/scripts/group-forms/components/EditGroupMembersForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@ export default function EditGroupMembersForm({
rows={members ?? []}
columns={columns}
renderItem={renderRow}
loading={!members}
/>
</Scroll>
</div>
Expand Down
2 changes: 2 additions & 0 deletions h/static/scripts/group-forms/components/test/EditGroupMembersForm-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,11 @@ describe('EditGroupMembersForm', () => {
headers: config.api.readGroupMembers.headers,
}),
);
assert.isTrue(wrapper.find('DataTable').prop('loading'));

await waitForTable(wrapper);

assert.isFalse(wrapper.find('DataTable').prop('loading'));
const users = getRenderedUsers(wrapper);
assert.deepEqual(users, ['bob', 'johnsmith', 'jane']);
});
Expand Down
Loading