Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra bytes display for composed SSK #16

Merged
merged 1 commit into from
Oct 17, 2021

Conversation

TheSeeker
Copy link
Contributor

Fix for composed private SSK displaying as AQICAAE instead of AQECAAE.

Fix for composed private SSK displaying as AQICAAE instead of AQECAAE.
@Thynix
Copy link
Contributor

Thynix commented May 27, 2021

I'm not familiar with this part of the code, and without reading and understanding the context it's not clear to me why there was a problem, or why the change fixes it. Could you please elaborate in the body of the commit message?

@Thynix
Copy link
Contributor

Thynix commented May 27, 2021

Also, the build is failing?? Not that this introduced the breakage.

@TheSeeker
Copy link
Contributor Author

Also, the build is failing?? Not that this introduced the breakage.

This was addressed in PR #17, while separately addressed by adding a wrapper function for the deprecated call.

@TheSeeker
Copy link
Contributor Author

I'm not familiar with this part of the code, and without reading and understanding the context it's not clear to me why there was a problem, or why the change fixes it. Could you please elaborate in the body of the commit message?

I have no idea how to edit the commit message from the github web interface, sorry. The Extra bytes for an SSK are (currently) either AQACAAE (public) or AQECAAE (private) but when composing the bytes for conversion to base64 and display, the wrong value (2) was being placed in the byte describing the key type when private, resulting in AQICAAE when it should be AQECAAE. see: https://github.com/freenet/fred/blob/next/src/freenet/keys/ClientSSK.java#L148

@ArneBab
Copy link
Contributor

ArneBab commented Oct 17, 2021

Tests work here with the merged #17, changes look good to me.

@ArneBab ArneBab merged commit 62849c1 into hyphanet:master Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants