Bugfix: skip in support.io.SkipShieldingInputStream must return non-negative #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ative value read() in skip(n) sometimes returns -1, but skip cannot return a negative number. This caused an infinite loop in recent versions of commons-compress (IOUtils.java) which introduced another while loop in it's skip function that assumed the overrided skip() function returned a non-negative value.
Bombe
requested changes
Jul 1, 2021
| @@ -46,6 +46,14 @@ public SkipShieldingInputStream(InputStream in) { | |||
|
|
|||
| @Override | |||
| public long skip(long n) throws IOException { | |||
| return n < 0 ? 0 : read(SKIP_BUFFER, 0, (int) Math.min(n, SKIP_BUFFER_SIZE)); | |||
| int retval; | |||
There was a problem hiding this comment.
Please don't add a variable just for the return value; returning the final value from where it's found is preferred.
There was a problem hiding this comment.
Well the whole point of this patch is to check the return value of that read() call to make sure it's not negative. How can that be done without introducing a return variable?
There was a problem hiding this comment.
Of course, if you need to store a return value, go right ahead but just for the sake of “only have a single exit point” (which is quite stupid)? Please don’t.
nextgens
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read() in skip(n) sometimes returns -1, but skip cannot return a negative number. This caused an infinite loop in recent versions of commons-compress (IOUtils.java) which introduced another while loop in it's skip function that assumed the overrided skip() function returned a non-negative value.