m3u-player: prevent flickering on track-transitions #734
Conversation
…ze fixed and overlaying an image of the video
|
🎉 I'll try this tonight! 👍 |
|
Yay! This is totally crazy by the way — actually taking snapshots of the video to smooth over breaks — but it’s what works. The next step in quality would be split-second fade-out and fade-in for audio. (and these small polishing steps are what’s needed to make some feature — almost any feature — actually enjoyable, just like my gms tweaks work towards making the streams just work, even in pure friend-to-friend mode) |
|
It's actually a very clever idea! :) |
|
Got to test it finally. Although there's the sound flickering that you mention the video is smoother now. 👍 |
|
Thank you for testing! |
|
@ArneBab can you please pay a bit attention to what you commit on which branch? Both the bookmark updates and the version number increase do not belong into this pull request. |
arg, sorry. I will fix this here. And there’s still a bit of work to be done: adjusting the canvas to the video size does not yet work in all cases. |
ArneBab
force-pushed
the
m3u-player-prevent-flickering
branch
from
1d737d7 to
0e55657
Compare
|
@Bombe the branch is cleaned up from stuff not belonging here now. |
|
@desyncr the latest commit should kill every flickering during transition. The only side-effect should be that the video stops dynamic size changes from resizing of the browser window while it is showing a loading spinner. It restarts them once the next part is loaded. It would be great if you could give this another review to see whether it can be merged. |
|
@desyncr so much for „last“: I found simplifications. Now it should be more robust and work well if the video element size is fixed to something that does not match the video aspect ratio. |
|
I'll take a look tonight! :) The dynamic resizing sounds look a very specific use-case so I'm not worried about that! |
|
Did you get to look into it? |
|
@ArneBab I could test it just now and looks way better! Both mobile and desktop. |
|
Thank you! |
prevent flickering on track-transitions by keeping the size fixed and overlaying an image of the video