Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for customizable static range labels #271
Support for customizable static range labels #271
Changes from 1 commit
c8ce7bd
fb15e54
5e4eb44
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make
hasCustomRendering
true
by default ifrenderStaticRangeLabel
already defined. You can still add another property calledrenderLabel()
to static range object for rendering custom range in order to render just for it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
staticRange.label
can already be rendered via a custom component (label: <MyComponent/>
); there's no need for singlerenderLabel
functions for individualstaticRange
on configuration object level. Whole point of having a render function on component level is let the callers specify custom props / logic to the label rendering logic on their own component's render phase. So yes; this means that if any of thestaticRange
configurations havehasCustomRendering
; then therenderStaticRangeLabel
prop should be present too. But the reverse is not true.Having
renderStaticRangeLabel
prop provided does not mean that every staticRange object will be rendered in a custom way. So we cannot changehasCustomRendering
totrue
by default if it's present. For example; in the original use-case we have right now is to be able to render a tooltip on one of thestaticRange
buttons while the others are continue to usestaticRange.label
.