Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate OLM Bundle for OperatorHub Release #195

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MuneebAijaz
Copy link

@MuneebAijaz MuneebAijaz commented Feb 12, 2025

Refers to: #72

@MuneebAijaz MuneebAijaz marked this pull request as draft February 12, 2025 19:01
@MuneebAijaz
Copy link
Author

@dmolik Hi, i have some questions here, $(VERSION) calculation in Makefile currently returns commit hash, can we support git tags there?

While setting up the project, i do get this error while running generators build constraints exclude all Go files in /usr/local/go/src/iter, I need guidance on how to set it up properly.

@dmolik
Copy link
Member

dmolik commented Feb 14, 2025

Hey @MuneebAijaz $(VERSION) does support git tags, the behavior is when HEAD matches a tag VERSION is the tag name so if you checkout v0.0.55, $(VERSION) will be v0.0.55. However on any given day HEAD is likely to be untaggged, so VERSION will be the short sha of the most recent commit. There is all so another variable $(SHA) which always gives the most recent short commit sha.

You're other error looks to be related to your go setup, what's $GOROOT and $GOPATH set to?

Sorry for the late response, I've been violently ill this week.

Finally keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants