check exit status on close

hyperspike · Aug 2, 2024 · 32e6a8e · 32e6a8e
1 parent 46181e8
commit 32e6a8e
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/internal/controller/valkey_controller.go b/internal/controller/valkey_controller.go
@@ -458,7 +458,9 @@ func (r *ValkeyReconciler) balanceNodes(ctx context.Context, valkey *hyperv1.Val
 			for {
 				network, err := net.Dial("tcp", addr+":6379")
 				if err != nil {
-					network.Close()
+					if err := network.Close(); err != nil {
+						logger.Error(err, "failed to close network", "valkey", valkey.Name, "namespace", valkey.Namespace)
+					}
 					time.Sleep(time.Second * 2)
 					dial++
 					if dial > 60 {
@@ -468,7 +470,9 @@ func (r *ValkeyReconciler) balanceNodes(ctx context.Context, valkey *hyperv1.Val
 					continue
 				}
 				if network != nil {
-					network.Close()
+					if err := network.Close(); err != nil {
+						logger.Error(err, "failed to close network", "valkey", valkey.Name, "namespace", valkey.Namespace)
+					}
 				} else {
 					time.Sleep(time.Second * 2)
 					dial++