Skip to content

Commit

Permalink
clean-up image builder
Browse files Browse the repository at this point in the history
  • Loading branch information
dmolik committed Nov 27, 2024
1 parent 6aae090 commit 30f0db4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
context: .
push: true
visibility: public
tags: ${{ steps.meta_manager.outputs.tags }}
tags: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}${{ env.RELEASE_VERSION }}
labels: ${{ steps.meta_manager.outputs.labels }}
- name: Build and push Sidecar image
uses: docker/build-push-action@4f58ea79222b3b9dc2c8bbdd6debcef730109a75
Expand All @@ -80,7 +80,7 @@ jobs:
context: .
push: true
visibility: public
tags: ${{ steps.meta_sidecar.outputs.tags }}
tags: ${{ env.REGISTRY }}/hyperspike/valkey-sidecar:${{ env.RELEASE_VERSION }}
labels: ${{ steps.meta_sidecar.outputs.labels }}
- name: Build and push Valkey image
uses: docker/build-push-action@4f58ea79222b3b9dc2c8bbdd6debcef730109a75
Expand All @@ -90,7 +90,7 @@ jobs:
context: .
push: true
visibility: public
tags: ${{ steps.meta_valkey.outputs.tags }}
tags: ${{ env.REGISTRY }}/hyperspike/valkey:${{ env.VALKEY_VERSION }}
labels: ${{ steps.meta_valkey.outputs.labels }}

- name: Set up Cosign
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/scan.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,14 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Build and push Valkey image
- name: Build the Valkey image
uses: docker/build-push-action@4f58ea79222b3b9dc2c8bbdd6debcef730109a75
id: docker_build_valkey
with:
file: Dockerfile.valkey
context: .
push: false
tags: ${{ env.REGISTRY }}/hyperspike/valkey:${{ github.SHA }}

- name: Run Trivy vulnerability scanner
uses: aquasecurity/trivy-action@master
with:
Expand Down

0 comments on commit 30f0db4

Please sign in to comment.