Skip to content

Commit

Permalink
update tooling and start on statefulsets function
Browse files Browse the repository at this point in the history
  • Loading branch information
dmolik committed Jan 23, 2025
1 parent be04ad5 commit 218adcf
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 8 deletions.
12 changes: 6 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ SHELL = /usr/bin/env bash -o pipefail

K8S_VERSION ?= 1.32.1
ENVTEST_K8S_VERSION = $(K8S_VERSION)
CILIUM_VERSION ?= 1.16.5
CILIUM_VERSION ?= 1.16.6
VALKEY_VERSION ?= 8.0.2

V ?= 0
Expand Down Expand Up @@ -241,12 +241,12 @@ GOSEC ?= $(LOCALBIN)/gosec-$(GOSEC_VERSION)

## Tool Versions
KUSTOMIZE_VERSION ?= v5.4.1
CONTROLLER_TOOLS_VERSION ?= v0.16.5
CONTROLLER_TOOLS_VERSION ?= v0.17.1
ENVTEST_VERSION ?= release-0.18
GOLANGCI_LINT_VERSION ?= v1.61.0
HELMIFY_VERSION ?= v0.4.14
HELM_VERSION ?= v3.15.4
GOSEC_VERSION ?= v2.20.0
GOLANGCI_LINT_VERSION ?= v1.63.4
HELMIFY_VERSION ?= v0.4.17
HELM_VERSION ?= v3.16.2
GOSEC_VERSION ?= v2.22.0

helm-gen: manifests kustomize helmify ## Generate Helm chart from Kustomize manifests
$Qcd config/manager && $(KUSTOMIZE) edit set image controller=${IMG_CONTROLLER}
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/hyperspike.io_valkeys.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.5
controller-gen.kubebuilder.io/version: v0.17.1
name: valkeys.hyperspike.io
spec:
group: hyperspike.io
Expand Down
17 changes: 16 additions & 1 deletion internal/controller/valkey_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -2006,7 +2006,20 @@ func getInitContainerResourceRequirements() corev1.ResourceRequirements {
}
}

func (r *ValkeyReconciler) upsertStatefulSet(ctx context.Context, valkey *hyperv1.Valkey) error {
/*
* Create a new StatefulSet for each Valkey Shard (Node)
*/
func (r *ValkeyReconciler) upsertStatefulSets(ctx context.Context, valkey *hyperv1.Valkey) error { // {{{

Check failure on line 2012 in internal/controller/valkey_controller.go

View workflow job for this annotation

GitHub Actions / lint

func `(*ValkeyReconciler).upsertStatefulSets` is unused (unused)
logger := log.FromContext(ctx)

logger.Info("upserting statefulsets")

return nil
}

// }}}

func (r *ValkeyReconciler) upsertStatefulSet(ctx context.Context, valkey *hyperv1.Valkey) error { // {{{
logger := log.FromContext(ctx)

logger.Info("upserting statefulset")
Expand Down Expand Up @@ -2396,6 +2409,8 @@ func (r *ValkeyReconciler) upsertStatefulSet(ctx context.Context, valkey *hyperv
return nil
}

// }}}

// SetupWithManager sets up the controller with the Manager.
func (r *ValkeyReconciler) SetupWithManager(mgr ctrl.Manager) error {
return ctrl.NewControllerManagedBy(mgr).
Expand Down

0 comments on commit 218adcf

Please sign in to comment.