Merge pull request #127 from hyperspike/pvc-bug

bug(storage): Fix label assignment in PVCs
hyperspike · Nov 27, 2024 · 0a07573 · 0a07573
2 parents 0509620 + 7395896
commit 0a07573
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/internal/controller/valkey_controller.go b/internal/controller/valkey_controller.go
@@ -1730,8 +1730,12 @@ func generatePVC(valkey *hyperv1.Valkey) corev1.PersistentVolumeClaim {
 	if valkey.Spec.Storage != nil {
 		pv = *valkey.Spec.Storage
 		pv.ObjectMeta.Name = "valkey-data"
-		for k, v := range labels(valkey) {
-			pv.ObjectMeta.Labels[k] = v
+		if pv.ObjectMeta.Labels == nil {
+			pv.ObjectMeta.Labels = labels(valkey)
+		} else {
+			for k, v := range labels(valkey) {
+				pv.ObjectMeta.Labels[k] = v
+			}
 		}
 	}
 	return pv