Update swiftlint rules

[onmyway133]

Having a lot of warnings can confuse us, so it's great that we can have a common set of rules that we agree on

unused_closure_parameter

This can cause issue like realm/SwiftLint#1175 when the function is generic

closure_parameter_position

This rule is good. However in cases similar to Cartography when the list of closure parameters is long, we tend to move them to a new line

constrain(percentageLabel, titleLabel) {
      (percentageLabel: LayoutProxy, titleLabel: LayoutProxy) in

      // ...
}

empty_parentheses_with_trailing_closure

This rule is good. However in cases we have a constructor that accepts a closure, we tend to call it like let person = Person() { ... } instead of let person = Person { ... } which makes the intention more clear that we 're constructing an object

redundant_string_enum_value

I have no strong opinion on this actually. It is redundant in a way, but more explicit in another way 🤔

enum Deployment: String {
   case staging = "staging"
   case production = "production"
}

min_length

This is good. But since it confuses public typealias T = U with variable name constraints, so I reduce it to 1 for now

[JohnSundell]

🌷

[vadymmarkov]

As for redundant_string_enum_value, I kinda like to rely on default value.

[onmyway133]

@vadymmarkov me too, but for some projects, they may not be the same, so to be safe, I disable it