Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix size type in json dictionary #24

Merged
merged 1 commit into from
Oct 19, 2016
Merged

Fix size type in json dictionary #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/Shared/Item.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ public struct Item: Mappable, Indexable {
Key.Index.string : index,
Key.Kind.string : kind,
Key.Size.string : [
Key.Width.string : size.width,
Key.Height.string : size.height
Key.Width.string : Double(size.width),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that @vadymmarkov ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because in init we map it as a Double. And seems like Double is a default type for floating numbers in json in swift 3.

Key.Height.string : Double(size.height)
]
]

Expand Down