Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature text property #21

Merged
merged 5 commits into from
Oct 3, 2016
Merged

Feature text property #21

merged 5 commits into from
Oct 3, 2016

Conversation

zenangst
Copy link
Contributor

@zenangst zenangst commented Oct 3, 2016

We have had quiet a few cases where we have to fallback to use meta when showing longer pieces of text when displaying an Item.

By adding text has a property, you get one more field that you can rely on and it fits quiet a lot of cases.

It won’t solve everything that in my opinion I think it’s an okay thing to have on the Item.

@zenangst
Copy link
Contributor Author

zenangst commented Oct 3, 2016

This is not a breaking change because the field is optional and defaults to empty string.

@vadymmarkov vadymmarkov merged commit c87383c into master Oct 3, 2016
@vadymmarkov vadymmarkov deleted the feature/text-property branch October 3, 2016 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants